Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added envvars table needs an update due to newly added envvars #10576

Closed
mmattel opened this issue Nov 15, 2024 · 1 comment · Fixed by #10581
Closed

Added envvars table needs an update due to newly added envvars #10576

mmattel opened this issue Nov 15, 2024 · 1 comment · Fixed by #10581

Comments

@mmattel
Copy link
Contributor

mmattel commented Nov 15, 2024

Refernces:
#9267 (feat: add exif panel options to web config struct)
#10572 (limit the number of workers of the jsoncs3 share manager)

Both contain a new envvar that is currently not part of the added table but must be present for 7.0.0

#9267 will most likely be merged
#10572 was merged

IMPORTANT:
#10572 in my understanding, it misses the global envvar OCIS_MAX_CONCURRENCY and the text should be harmonized as we have in all max_concurrency envvars to: Maximum number of concurrent go-routines. Higher values can potentially get work done faster but will also cause more load on the system. Values of 0 or below will be ignored and the default value will be used.

When all set, I create a PR with the env_vars.yaml update and when merged another one containing the added table update.

@butonic @micbar

@mmattel
Copy link
Contributor Author

mmattel commented Nov 15, 2024

Note, #9267 has not been merged, it got closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant