Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web config var LoginURL #7317

Merged
merged 8 commits into from
Sep 20, 2023
Merged

Add web config var LoginURL #7317

merged 8 commits into from
Sep 20, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 20, 2023 •
edited
Loading

Description

Introduce a config to set the web login URL via WEB_OPTION_LOGIN_URL.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from mmattel September 20, 2023 07:53
@AlexAndBear AlexAndBear requested a review from mmattel September 20, 2023 08:07
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit e1148c6 into master Sep 20, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the web-login-config-var branch September 20, 2023 08:45
ownclouders pushed a commit that referenced this pull request Sep 20, 2023
Add web config var LoginURL (#7317)
9776ca4 
* Add web config var LoginURL

* Add changelog item
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@mmattel mmattel Awaiting requested review from mmattel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @mmattel @JammingBen