Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unary in the beginning. add tests #7247

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix unary in the beginning. add tests #7247

merged 1 commit into from
Sep 7, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Sep 7, 2023

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905 2403905 marked this pull request as ready for review September 7, 2023 09:25
@2403905 2403905 requested a review from fschade September 7, 2023 09:25
@2403905 2403905 force-pushed the enable-kql-fix-unary branch 2 times, most recently from 338e928 to ea2bc3a Compare September 7, 2023 09:43
@2403905 2403905 force-pushed the enable-kql-fix-unary branch from ea2bc3a to 158f91b Compare September 7, 2023 12:38
@2403905 2403905 changed the title fix unari in the beggining. add tests fix unary in the beginning. add tests Sep 7, 2023
fschade
fschade approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

61.9% 61.9% Coverage
0.0% 0.0% Duplication

@2403905 2403905 merged commit 3ab8226 into owncloud:master Sep 7, 2023
1 check passed
ownclouders pushed a commit that referenced this pull request Sep 7, 2023
@2403905
Merge pull request #7247 from 2403905/enable-kql-fix-unary
fc9b6c2 
fix unary in the beginning. add tests
This was referenced Sep 8, 2023
Merged
Merged
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2403905 @fschade