Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] fix typo in Then scenario steps #10777

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[tests-only][full-ci] fix typo in Then scenario steps #10777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/acceptance/bootstrap/SpacesContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ public function checkPermissionsInResponse(
}

/**
* @Then /^the json responded should not contain a space with name "([^"]*)"$/
* @Then /^the json response should not contain a space with name "([^"]*)"$/
*
* @param string $spaceName
*
Expand Down Expand Up @@ -1103,7 +1103,7 @@ public function theUserShouldHaveASpaceInTheDisableState(
}

/**
* @Then /^the json responded should (not|only|)\s?contain spaces of type "([^"]*)"$/
* @Then /^the json response should (not|only|)\s?contain spaces of type "([^"]*)"$/
*
* @param string $onlyOrNot (not|only|)
* @param string $type
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiGraphUserGroup/deleteUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Feature: delete user
When the user "Alice" deletes a user "Brian" using the Graph API
Then the HTTP status code should be "204"
When user "Alice" lists all spaces via the Graph API with query "$filter=driveType eq 'personal'"
Then the json responded should not contain a space with name "Brian Murphy"
Then the json response should not contain a space with name "Brian Murphy"


Scenario: accepted share is deleted automatically when the user is deleted
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiOcm/share.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ Feature: an user shares resources using ScienceMesh application
And using server "REMOTE"
When user "Brian" lists all available spaces via the Graph API
Then the HTTP status code should be "200"
And the json responded should not contain a space with name "folderToShare"
And the json response should not contain a space with name "folderToShare"

@issue-10213
Scenario Outline: local user removes access of federated user from a resource
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiSpaces/listSpaces.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ Feature: List and create spaces
}
}
"""
And the json responded should not contain a space with name "Shares"
And the json responded should only contain spaces of type "personal"
And the json response should not contain a space with name "Shares"
And the json response should only contain spaces of type "personal"


Scenario: ordinary user will not see any space when using a filter for project
Expand Down Expand Up @@ -183,7 +183,7 @@ Feature: List and create spaces
}
}
"""
And the json responded should not contain a space with name "Alice Hansen"
And the json response should not contain a space with name "Alice Hansen"


Scenario: ordinary user can access their space via the webDav API
Expand Down Expand Up @@ -435,7 +435,7 @@ Feature: List and create spaces
And user "Admin" has created a space "Project Venus" with the default quota using the Graph API
When user "Alice" tries to look up the single space "Project Venus" owned by the user "Admin" by using its id
Then the HTTP status code should be "404"
And the json responded should not contain a space with name "Project Venus"
And the json response should not contain a space with name "Project Venus"
Examples:
| user-role |
| User |
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiSpaces/spaceManagement.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Feature: Space management
}
}
"""
And the json responded should not contain a space with name "Alice Hansen"
And the json response should not contain a space with name "Alice Hansen"


Scenario: space admin user can see another personal spaces
Expand Down Expand Up @@ -80,14 +80,14 @@ Feature: Space management
}
}
"""
And the json responded should not contain a space with name "Project"
And the json response should not contain a space with name "Project"


Scenario: user without space admin permission cannot see another spaces
When user "Carol" tries to list all spaces via the Graph API
Then the HTTP status code should be "200"
And the json responded should not contain a space with name "Project"
And the json responded should not contain a space with name "Alice Hansen"
And the json response should not contain a space with name "Project"
And the json response should not contain a space with name "Alice Hansen"


Scenario: space admin user changes the name of the project space
Expand Down