Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include additional logging in the wopicontext middleware #10101

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

jvillafanez
Copy link
Member

Description

Include additional logs for errors inside the wopicontext middleware.
There have been cases where the wopi server returns a 401 (unauthorized) code, which suggest a problem in the wopicontext middleware, however, there are no logs about the cause of the error, which makes it very difficult to debug.
This PR just adds new logs for error cases. There is no change in the behavior nor in the log information.

Related Issue

Related to #10053

Motivation and Context

Troubleshooting for those 401 errors should be easier.

How Has This Been Tested?

Partially tested manually by making a request to the wopi server with wrong data. Seen the "missing access token" and "failed to parse jwt token". The rest might require a more carefully crafted token, so it's more difficult to prove, but the risk is very low.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez jvillafanez self-assigned this Sep 18, 2024
Copy link

update-docs bot commented Sep 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Sep 18, 2024

@jvillafanez jvillafanez merged commit fddad37 into master Sep 19, 2024
4 checks passed
@jvillafanez jvillafanez deleted the collaboration_wopicontext_logging branch September 19, 2024 08:32
ownclouders pushed a commit that referenced this pull request Sep 19, 2024
…ging

fix: include additional logging in the wopicontext middleware
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants