Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed endpoint for app provider apps #9489

Closed
13 tasks
kulmann opened this issue Jun 27, 2024 · 3 comments
Closed
13 tasks

fixed endpoint for app provider apps #9489

kulmann opened this issue Jun 27, 2024 · 3 comments
Labels
Type:Story User Story

Comments

@kulmann
Copy link
Member

kulmann commented Jun 27, 2024

Description

The endpoint for app provider mimetype to app mappings gets announced via capabilities. This makes it unnecessarily complex in web to fetch the app provider listing and dynamically register the web-apps according to the listing. It would be far easier if it was a fixed endpoint (not announced by capability but a fixed route in the ocis proxy) which would return an empty list if no app provider apps are registered. Additionally it would be nice if the endpoint would work unauthenticated.

User Stories

  • As a web ui developer, I want to have a fixed endpoint for the app provider listing, so that I can keep my app initialization as easy as possible.

Value

DX for the web client

Acceptance Criteria

  • an endpoint that can be hardcoded in web (instead of looking it up in the capabilities)
  • ideally unauthenticated if that's not a security concern
  • returns an empty list if no app provider apps are configured server side

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
  • Configuration changes
    • The next branch of the ocis charts is compatible
@kulmann kulmann added the Type:Story User Story label Jun 27, 2024
@kulmann kulmann moved this from Qualification to Backlog in Infinite Scale Team Board Jun 27, 2024
@kulmann
Copy link
Member Author

kulmann commented Jul 11, 2024

@micbar all 3 acceptance criteria are already fulfilled, correct? What about the third, returning an empty list if no app provider is set up at all, does that work as well?

@micbar
Copy link
Contributor

micbar commented Jul 11, 2024

Correct. It will always show up, can be accessed unauthenticated and returns an empty json body if apps are not or not yet available.

@kulmann
Copy link
Member Author

kulmann commented Jul 11, 2024

Thank you! Then we can close here 😎

@kulmann kulmann closed this as completed Jul 11, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Infinite Scale Team Board Jul 11, 2024
kulmann added a commit to owncloud/web that referenced this issue Jul 16, 2024
Since the ocis backend guarantees that the /app/list endpoint exists we
can hardcode the url and initialize the app provider apps before the
vue-router is being initialized. This saves us a redirect on page reload
in an app provider app.
See owncloud/ocis#9489
JammingBen pushed a commit to owncloud/web that referenced this issue Jul 18, 2024
Since the ocis backend guarantees that the /app/list endpoint exists we
can hardcode the url and initialize the app provider apps before the
vue-router is being initialized. This saves us a redirect on page reload
in an app provider app.
See owncloud/ocis#9489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Status: Done
Development

No branches or pull requests

2 participants