Pull in fork test from hub

[owenthereal]

See mislav/hub@efe8c97...7672e14

[owenthereal]

@mislav I'm trying to pull in some compatibility code from hub. But I'm not sure how the changes fix the asynchronous forking repo availability issue: it first remote adds and then set-url. Is there any magic I missed from git 😸?

[mislav]

Before, it would add the "jingweno" remote and immediately try to fetch from your fork. In some cases, the new git repo wouldn't be ready yet on GitHub.com.

Now, it adds the "jingweno" remote to point to "origin", fetches that, then changes the URL to actually point to your fork.

[owenthereal]

Ah, I think I missed that git remote add -f runs git fetch as well. Thanks @mislav

[owenthereal]

Actually why do we need to fetch? Isn't that the root cause of the problem is fetching a repo that is potentially not ready? How about just git remote add without the fetch and let the users fetch themselves?

[mislav]

Yes, the root cause was the fetch, but now we're fetching from origin, which is sure to be ready ;) and renaming that to "yourfork" after the fetch.

The fetch isn't crucial here, but I'd like to have the current state of user's fork reflected in the remote tracking branches so that future operations are predictable, like checking if you've pushed all commits before making a pull-request, and similar.

[owenthereal]

Closing. Further development goes to mislav/hub#475