-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: KeyObject
helper functions return JSCryptoKey
#15658
Open
DonIsaac
wants to merge
5
commits into
main
Choose a base branch
from
don/refactor/key-object-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures
cirospaciari
reviewed
Dec 9, 2024
cirospaciari
reviewed
Dec 9, 2024
@@ -88,6 +88,12 @@ JSC_DECLARE_HOST_FUNCTION(KeyObject__privateDecrypt); | |||
|
|||
namespace WebCore { | |||
|
|||
/// Encodes `undefined` if `key` is `nullptr`. | |||
JSC::EncodedJSValue encodeKey(const std::optional<JSCryptoKey*> key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would choose another name here just to add what is being encoded and to what is being encoded example: encodeKeyObjectToJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors helper functions in
KeyObject.cpp
to returnJSCryptoKey
objects instead ofEncodeJSValue
s, along with some other minor refactors. Prereq refactor toKeyObject
JS -> native migration. Part of #15585.Note to reviewers: I recommend reviewing each commit individually.
How did you verify your code works?
Tests already exist for this logic.