Bugfix: HEVC SRT stream supports multiple PPS fields. v6.0.76

[xengine-qyt]

Please describe the summary for this PR.

when the srs have multiple pps in hevc.the srs can't parse for this.
problem fixed this #3604

---

Co-authored-by: chundonglinlin [email protected]
Co-authored-by: john [email protected]

[chundonglinlin]

I'm glad to know that the code modifications I provided worked perfectly for supporting multiple PPS fields. But the gb28181 and utest codes failed the testing because the interface is reused.

[xengine-qyt]

OK ,modified.

[xiaozhihong]

Is it possible for you to generate a new pull request to add support for multiple PPS in H.264? Thank you.

[xengine-qyt]

yes,of course,just for the h264 of ts?

[xiaozhihong]

yes,of course,just for the h264 of ts?

Include ts, rtmp and webrtc.

The code below should be refactor.

srs/trunk/src/kernel/srs_kernel_codec.cpp

Lines 2213 to 2224 in 73dd8af

	// Support for multiple PPS, then pick the first non-empty one.
	for (int i = 0; i < numOfPictureParameterSets; ++i) {
	if (!stream->require(2)) {
	return srs_error_new(ERROR_HLS_DECODE_ERROR, "decode PPS size");
	}
	uint16_t pictureParameterSetLength = stream->read_2bytes();
	if (!stream->require(pictureParameterSetLength)) {
	return srs_error_new(ERROR_HLS_DECODE_ERROR, "decode PPS data");
	}
	if (pictureParameterSetLength > 0) {
	vcodec->pictureParameterSetNALUnit.resize(pictureParameterSetLength);
	stream->read_bytes(&vcodec->pictureParameterSetNALUnit[0], pictureParameterSetLength);

[xengine-qyt]

why refactor?

[xiaozhihong]

why refactor?

Because PR needs to ensure integrity and fully address the issues of multiple PPS, if there are multiple PPS here, the code will be overwritten.

TRANS_BY_GPT3

[chundonglinlin]

Two experts, there are also multiple issues with h264's PPS, and there were comments explaining the support for 264 at that time. Should we just confirm and improve this PR or open a new PR to make changes?
@xengine-qyt @xiaozhihong

TRANS_BY_GPT3

[xengine-qyt]

why refactor?

Because PR needs to ensure integrity and fully address the issues of multiple PPS, if there are multiple PPS here, the code will be overwritten.

TRANS_BY_GPT3

sorry, I haven't read the code here, so I don't know much about it

[chundonglinlin]

why refactor?

Because PR needs to ensure integrity and fully address the issues of multiple PPS, if there are multiple PPS here, the code will be overwritten.
TRANS_BY_GPT3

sorry, I haven't read the code here, so I don't know much about it

Can the h264 pps be modified? The h264 pps is stored using vector<char>, and when numOfPictureParameterSets > 0, it will be overwritten multiple times and only the last pps is recorded. @xengine-qyt '
Please ensure to maintain the markdown structure.

TRANS_BY_GPT4

[xengine-qyt]

why refactor?

Because PR needs to ensure integrity and fully address the issues of multiple PPS, if there are multiple PPS here, the code will be overwritten.
TRANS_BY_GPT3

sorry, I haven't read the code here, so I don't know much about it

Can the h264 pps be modified? The h264 pps is stored using vector<char>, and when numOfPictureParameterSets > 0, it will be overwritten multiple times and only the last pps is recorded. @xengine-qyt ' Please ensure to maintain the markdown structure.

TRANS_BY_GPT4

sorry,i have no mulit pps device for h264,I am afraid that the modify is not correct, I recommend you to modify it.

[xiaozhihong]

why refactor?

Because PR needs to ensure integrity and fully address the issues of multiple PPS, if there are multiple PPS here, the code will be overwritten.
TRANS_BY_GPT3

sorry, I haven't read the code here, so I don't know much about it

Can the h264 pps be modified? The h264 pps is stored using vector<char>, and when numOfPictureParameterSets > 0, it will be overwritten multiple times and only the last pps is recorded. @xengine-qyt ' Please ensure to maintain the markdown structure.
TRANS_BY_GPT4

sorry,i have no mulit pps device for h264,I am afraid that the modify is not correct, I recommend you to modify it.

Um, okay, thank you very much for the PR, we will handle the rest of the modifications.