Fix pip installation #30
Conversation
version pinning needed to avoid bad versions
|
|
||
| ``` | ||
| bundle install |
There was a problem hiding this comment.
This won't do anything if you just install through pip, so I deleted this section.
There was a problem hiding this comment.
This is needed for auditing Rubygems packages.
|
|
||
| ``` | ||
| bundle install |
There was a problem hiding this comment.
This is needed for auditing Rubygems packages.
| @@ -20,7 +20,7 @@ | |||
| long_description_content_type = 'text/markdown' | |||
|
|
|||
| # this grabs the requirements from requirements.txt | |||
| REQUIREMENTS = [i.strip().split('==')[0] for i in open(os.path.join(here, "requirements.txt")).readlines()] | |||
| REQUIREMENTS = [i.strip() for i in open(os.path.join(here, "requirements.txt")).readlines()] | |||
There was a problem hiding this comment.
Pinning deps is ideal, but this results in incompatibilities with different Python versions. I will test this.
Thanks for the testing! |
This should fix #6. Relevant: https://stackoverflow.com/questions/65326080/python-setup-config-install-requires-good-practices. I confirmed that packj
auditandauthworks with the pinned versions.It also adds directions for avoiding #10