🌱 make maintained values keys constants #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Korczynski <[email protected]>
AdamKorcz
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 76.39% 68.66% -7.73%
==========================================
Files 209 209
Lines 14310 14310
==========================================
- Hits 10932 9826 -1106
- Misses 2737 3916 +1179
+ Partials 641 568 -73 |
raghavkaul
approved these changes
Nov 28, 2023
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Converts the Maintained finding value keys to constants as discussed in #3641.
PR title follows the guidelines defined in our pull request documentation
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Part of #3641
Special notes for your reviewer
Does this PR introduce a user-facing change?
NONE