Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 convert CITest check to probes #3621

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

This PR converts the CITest check to probes.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE


@AdamKorcz AdamKorcz requested a review from a team as a code owner October 28, 2023 16:08
@AdamKorcz AdamKorcz requested review from justaugustus and spencerschrock and removed request for a team October 28, 2023 16:08
@AdamKorcz AdamKorcz temporarily deployed to gitlab October 28, 2023 16:09 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz temporarily deployed to gitlab October 28, 2023 16:14 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #3621 (0bf5cad) into main (5dc03b7) will decrease coverage by 5.65%.
The diff coverage is 63.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
- Coverage   76.35%   70.71%   -5.65%     
==========================================
  Files         213      214       +1     
  Lines       14557    14625      +68     
==========================================
- Hits        11115    10342     -773     
- Misses       2783     3672     +889     
+ Partials      659      611      -48     

Copy link

This pull request is stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Nov 12, 2023
@github-actions github-actions bot removed the Stale label Nov 21, 2023
Copy link

github-actions bot commented Dec 2, 2023

This pull request is stale because it has been open for 10 days with no activity

checks/evaluation/ci_tests.go Outdated Show resolved Hide resolved
probes/testsRunInCI/impl.go Outdated Show resolved Hide resolved
checks/evaluation/ci_tests.go Outdated Show resolved Hide resolved
probes/testsRunInCI/def.yml Outdated Show resolved Hide resolved
checks/evaluation/ci_tests_test.go Show resolved Hide resolved
probes/testsRunInCI/impl_test.go Show resolved Hide resolved
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively approved, pending last conversation

Signed-off-by: Adam Korczynski <[email protected]>
@spencerschrock
Copy link
Member

/scdiff generate CI-Tests

Copy link

@spencerschrock spencerschrock merged commit 30ef6b1 into ossf:main Dec 11, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants