-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Convert Dangerous Workflow check to probes #3521
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
===========================================
- Coverage 76.13% 65.22% -10.92%
===========================================
Files 199 201 +2
Lines 13738 13850 +112
===========================================
- Hits 10460 9033 -1427
- Misses 2668 4314 +1646
+ Partials 610 503 -107 |
Stale pull request message |
@laurentsimon @spencerschrock PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a bit of a skim to highlight the big comments.
086aeaa
to
f1ad11a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like comments were addressed, thanks
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
e0b7800
to
1aa59fe
Compare
* 🌱 Convert Dangerous Workflow check to probes Signed-off-by: AdamKorcz <[email protected]> * remove hasAnyWorkflows probe Signed-off-by: AdamKorcz <[email protected]> * combine two conditionals into one Signed-off-by: AdamKorcz <[email protected]> * preserve logging from original evaluation Signed-off-by: AdamKorcz <[email protected]> * rebase Signed-off-by: AdamKorcz <[email protected]> --------- Signed-off-by: AdamKorcz <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
* 🌱 Convert Dangerous Workflow check to probes Signed-off-by: AdamKorcz <[email protected]> * remove hasAnyWorkflows probe Signed-off-by: AdamKorcz <[email protected]> * combine two conditionals into one Signed-off-by: AdamKorcz <[email protected]> * preserve logging from original evaluation Signed-off-by: AdamKorcz <[email protected]> * rebase Signed-off-by: AdamKorcz <[email protected]> --------- Signed-off-by: AdamKorcz <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
What kind of change does this PR introduce?
feature
What is the new behavior (if this is a feature change)?**
This PR converts the Dangerous Workflows check to probes.
Which issue(s) this PR fixes
NONE
Does this PR introduce a user-facing change?
NONE