Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for RequiresLastPushReview in Branch Protection for GitHub #2492

Merged
merged 10 commits into from
Dec 14, 2022

Conversation

laurentsimon
Copy link
Contributor

closes #2475

GitHub introduced a new branch protection setting called "Require approval of the most recent push". It seems to be retrievable only via an admin token.

Add support for RequiresLastPushReview in Branch Protection for GitHub repos

@laurentsimon
Copy link
Contributor Author

friendly ping for review.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2492 (abbf355) into main (746b6e9) will increase coverage by 0.05%.
The diff coverage is 94.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2492      +/-   ##
==========================================
+ Coverage   39.92%   39.97%   +0.05%     
==========================================
  Files         122      122              
  Lines        9852     9863      +11     
==========================================
+ Hits         3933     3943      +10     
- Misses       5637     5638       +1     
  Partials      282      282              

@laurentsimon
Copy link
Contributor Author

@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem.

@spencerschrock
Copy link
Member

@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem.

Following up offline for more details. Likely an issue with which tokens we're using for our e2e tests and for criticality score @calebbrown fyi

@spencerschrock
Copy link
Member

#2478, #2442, and possibly #2407, all increase token usage

@laurentsimon
Copy link
Contributor Author

Anyone has cycles to review this PR?

@laurentsimon laurentsimon force-pushed the feat/lastapproval branch 3 times, most recently from 34aaf14 to a87712d Compare December 7, 2022 17:13
@laurentsimon laurentsimon enabled auto-merge (squash) December 7, 2022 17:13
@laurentsimon
Copy link
Contributor Author

laurentsimon commented Dec 7, 2022

rate limiting hit :/ @spencerschrock did you re-create a PAT?

e2e/branch_protection_test.go Outdated Show resolved Hide resolved
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
@laurentsimon laurentsimon temporarily deployed to integration-test December 14, 2022 18:14 — with GitHub Actions Inactive
@github-actions
Copy link

Integration tests success for
[abbf355]
(https://github.com/ossf/scorecard/actions/runs/3697566748)

Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentsimon laurentsimon merged commit a71b47e into ossf:main Dec 14, 2022
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
…Hub (ossf#2492)

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

* update

Signed-off-by: laurentsimon <[email protected]>

Signed-off-by: laurentsimon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features: Add "Require approval of the most recent push" to Branch protection check
6 participants