-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for RequiresLastPushReview in Branch Protection for GitHub #2492
Conversation
f65607c
to
3a699bb
Compare
friendly ping for review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
==========================================
+ Coverage 39.92% 39.97% +0.05%
==========================================
Files 122 122
Lines 9852 9863 +11
==========================================
+ Hits 3933 3943 +10
- Misses 5637 5638 +1
Partials 282 282 |
@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem. |
Following up offline for more details. Likely an issue with which tokens we're using for our e2e tests and for criticality score @calebbrown fyi |
Anyone has cycles to review this PR? |
34aaf14
to
a87712d
Compare
rate limiting hit :/ @spencerschrock did you re-create a PAT? |
0fe8e14
to
c385756
Compare
4b9bdbc
to
20eeabb
Compare
20eeabb
to
37941b5
Compare
3f100fe
to
28e0505
Compare
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
675163b
to
abbf355
Compare
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Hub (ossf#2492) * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> Signed-off-by: laurentsimon <[email protected]>
closes #2475
GitHub introduced a new branch protection setting called "Require approval of the most recent push". It seems to be retrievable only via an admin token.