Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Humble #20

Closed
wants to merge 7 commits into from
Closed

Upgrade to Humble #20

wants to merge 7 commits into from

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 16, 2022

This is open for review. There are outstanding warnings to be fixed upstream:

@chapulina chapulina self-assigned this Aug 16, 2022
@chapulina
Copy link
Contributor Author

Ouch I think we'll need to split this package (ros2/ros2_documentation#2882):

Calling rosidl_generate_interfaces and ament_python_install_package in the same CMake project does not work.
See this Github issue for more info. It is best practice to instead
separate out the message generation into a separate package.

@andermi
Copy link
Collaborator

andermi commented Aug 17, 2022

No problem. This was a bit non-standard anyways...
I opened an issue to discuss the re-org #21

@andermi andermi mentioned this pull request Aug 18, 2022
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the chapulina/humble_garden branch from 82a4d00 to badb282 Compare August 29, 2022 19:50
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

We're getting the import order errors with Humble, @quarkytale , I think we need to release ros2/rosidl_python#173 for Humble.

@chapulina
Copy link
Contributor Author

We're getting warnings like this, which is known upstream: ament/ament_cmake#382

2022-08-29T21:20:34.0172029Z =============================== warnings summary ===============================
2022-08-29T21:20:34.0191249Z test/test_flake8.py::test_flake8
2022-08-29T21:20:34.0198098Z test/test_flake8.py::test_flake8
2022-08-29T21:20:34.0205103Z   /usr/lib/python3/dist-packages/flake8/plugins/manager.py:261: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
2022-08-29T21:20:34.0211404Z     eps = importlib_metadata.entry_points().get(self.namespace, ())
2022-08-29T21:20:34.0217052Z 
2022-08-29T21:20:34.0222950Z -- Docs: https://docs.pytest.org/en/stable/warnings.html
2022-08-29T21:20:34.0237341Z test/test_pep257.py .                                                    [100%]
2022-08-29T21:20:34.0243053Z ------- generated xml file: /github/home/ws/build/buoy_api_py/pytest.xml -------
2022-08-29T21:20:34.0248659Z ======================== 3 passed, 2 warnings in 0.61s =========================
2022-08-29T21:20:34.1087909Z --- stderr: buoy_api_py

@chapulina chapulina marked this pull request as ready for review August 29, 2022 23:01
@quarkytale
Copy link
Contributor

quarkytale commented Aug 30, 2022

Sorry just saw this now, will look into forward porting rosidl_python!

@quarkytale
Copy link
Contributor

Humble backport PR #183

@chapulina
Copy link
Contributor Author

To be followed up on another PR

@chapulina chapulina closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants