Port downloadaudio to Anki 2.1

[marciomazza]

What I did

I completely port the Download Audio add-on until I couldn't find any bug.

I did not test other add-ons, but incidentally made these broad changes to all codebase:

• some porting from PyQt4 to PyQt5
• some 2to3 fixes
• porting to BeautfulSoup 4 (the version used by Anki)

I used these references as guides:

• http://pyqt.sourceforge.net/Docs/PyQt5/pyqt4_differences.html
• the main porting commit from Anki itself: ankitects/anki@de7e4

Please note that I do not know PyQt and this is the first time I see Anki's or this repo's source, so mistakes are expected. I tried my best though, to make at least downloadaudio work.

Points I suggest you revise

• The uses of BeautifulSoup constructor, especially the occurences of BeautifulSoup(text, 'html.parser'). Maybe they should use another parser.
• Some suppressions I made of encoding/decoding strings. I removed only parts which where causing bugs by changed semantics on python 3

[ospalh]

I don't quite understand this change.
Yes, AudioDownloader.init sets its url.
But that is called before this. So url gots set to "" after it got set in the old line 37?
(Honest question. I thought it worked before.)

[ospalh]

Thanks.
It is at least a great starting point. And possibly some will work just like this. For those, this will be just great. 😄
As i noted, i don't exactly get one of your changes. I'll deal with that some time later.
Anyway, I'll just merge this now.

[ospalh]

Oh, there is one change i should do before i release these:
I should credit you in the file headers. 😄
(Unless you explicitly say you don't want to.)

[ospalh]

One more point:
I stuck to BS, even though i find the name rather fitting, because that is what Anki itself uses. I know that BS will be there. Easier than bringing your own parser along.

[marciomazza]

The bug in WiktionaryDownloader was actually caused by this line:
https://github.com/ospalh/anki-addons/blob/develop/downloadaudio/downloaders/downloader.py#L134
which expects self.url to be just a prefix.
Before the fix it, when this line was executed, self.url would have the value http://{0}.wiktionary.org/wiki/{1}. The language part {0} had to be resolved by then.

All the rest of the downloaders treat AudioDownloader.url as a prefix, so now WiktionaryDownloader goes along.

The property setter for WiktionaryDownloader.url is necessary because without it the line
https://github.com/ospalh/anki-addons/blob/develop/downloadaudio/downloaders/downloader.py#L55
would raise an exception.

[marciomazza]

Thanks for the credit and for the add-on. It really makes a difference on my study.

[ospalh]

Did you really see any problems without turning url into a property?
Because the line you pointed to should not be called for WiktionaryDownloader/wiktionary.py, because that reimplements maybe_get_icon(), the function you pointed to.
eta:
here

[marciomazza]

It was called when I was testing. Em 30 de nov de 2016 9:57 AM, "ospalh" <[email protected]> escreveu:

…

Did you really see any problems without turning url into a property? Because the line you pointed to should *not* be called for WiktionaryDownloader/wiktionary.py, because that reimplements maybe_get_icon(), the function you pointed to. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#95 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjYUV-lrBLeO0z__Un-9VNzOT1EE-gBks5rDWSXgaJpZM4K_i66> .

[marciomazza]

Maybe you could run it without that commit and see what you get. Em 30 de nov de 2016 10:04 AM, "Marcio Mazza" <[email protected]> escreveu:

…

It was called when I was testing. Em 30 de nov de 2016 9:57 AM, "ospalh" ***@***.***> escreveu: > Did you really see any problems without turning url into a property? > Because the line you pointed to should *not* be called for > WiktionaryDownloader/wiktionary.py, because that reimplements > maybe_get_icon(), the function you pointed to. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#95 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAjYUV-lrBLeO0z__Un-9VNzOT1EE-gBks5rDWSXgaJpZM4K_i66> > . >

[ospalh]

Well, i can’t run it with Anki 2.1/Python3, and with Anki 2.0/Python 2 it is fetching the wiktionary site icon.

[marciomazza]

Yes... I found it difficult to set up Anki 2.1. If you want any help, I'm here. Em 30 de nov de 2016 10:13 AM, "ospalh" <[email protected]> escreveu:

…

Well, i can’t <https://ospalh.github.io/anki-addons/2016/11/30/Python_3.html> run it with Anki 2.1/Python3, and with Anki 2.0/Python 2 it is fetching the wiktionary site icon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#95 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjYUezGHp-OWTRFZHTUWc-y3Mfq5DLEks5rDWhPgaJpZM4K_i66> .