Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with "Multiple 'Add' and 'Browser' Windows" add-on #102

Open
dochypermoose opened this issue Feb 15, 2017 · 6 comments · May be fixed by #105
Open

Doesn't work with "Multiple 'Add' and 'Browser' Windows" add-on #102

dochypermoose opened this issue Feb 15, 2017 · 6 comments · May be fixed by #105
Labels

Comments

@dochypermoose
Copy link

Is there some way to get your add-on to work with the "Multiple 'Add' and 'Browser' Windows" ... that other one seems to prevent yours from actually switching note types (doesn't affect decks though). I don't know enough (read: anything at all) about code to find/fix the issue.

Multiple 'Add' and 'Browser' Windows
https://ankiweb.net/shared/info/969743069

@ospalh
Copy link
Owner

ospalh commented Feb 15, 2017

  • Which add-on? There’s more than one here.
  • Probably not. When both add-ons modify the same bit of the original Anki code, it can happen that one undoes the effect of the other. Maybe there is a way to make both work at the same time, but if, as you say, they don’t , then it may be more work then i am willing to invest here.

@dochypermoose
Copy link
Author

Ah sorry. It's your "Quick note and deck buttons" add-on.

@ospalh
Copy link
Owner

ospalh commented Feb 15, 2017

Well, thanks for that bit of information.
Then again, i’m a bit sorry, but i’ve mostly lost interest in all these add-ons. They work well enough for me, and when people want something more, e.g. one specific add-on to work together with some other random add-on by somebody else, well, i may look into it when i have nothing else to do, which may take a long time.
Sorry, but you may be better of fixing this yourself. Or using the standard deck/model selector.

@dochypermoose
Copy link
Author

Ah ok thanks!

@glutanimate
Copy link
Contributor

I'm a bit late to the party, but you can fix the incompatibility by editing the source code of the multiple windows add-on and removing everything below the following line:

# The following code prevents a change of note type in one AddCards dialog from affecting others.?

@ospalh ospalh added the sep label Apr 11, 2017
@RonilPatel7
Copy link

RonilPatel7 commented Apr 13, 2017

I made the change that you had suggested; while this change allows the "quick button add on to work" it makes the changes in all of the "multiple add windows"

Do you think it is possible to have a change in note type in add window # 1 not to affect the note type in add window # 2?

Or do the hooks for global note type changes make it difficult for this to be possible?

glutanimate added a commit to glutanimate/anki-addons-ospalh that referenced this issue Apr 13, 2017
Not the prettiest solution, but it should fix ospalh#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants