Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy.go for lockup module #879

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

mattverse
Copy link
Member

Closes: #XXX

Description

Per conversation in #804 to re-delete legacy.go


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #879 (6a178a1) into main (bdff1da) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   20.21%   20.30%   +0.09%     
==========================================
  Files         192      191       -1     
  Lines       24854    24740     -114     
==========================================
  Hits         5023     5023              
+ Misses      18907    18793     -114     
  Partials      924      924              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdff1da...6a178a1. Read the comment docs.

@mattverse mattverse changed the title Delete legacy.go Delete legacy.go for lockup module Feb 16, 2022
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@ValarDragon ValarDragon merged commit c24c7e4 into main Feb 16, 2022
@ValarDragon ValarDragon deleted the mattverse/clean-lockup branch February 16, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants