min duration from days to hours, changed weekly to day #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (weekly doesnt work its week)
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
=======================================
Coverage 19.86% 19.86%
=======================================
Files 190 190
Lines 24763 24763
=======================================
Hits 4918 4918
Misses 18982 18982
Partials 863 863
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Feb 13, 2022
x/lockup/client/cli/flags.go
Outdated
| @@ -14,13 +14,13 @@ const ( | |||
| func FlagSetLockTokens() *flag.FlagSet { | |||
| fs := flag.NewFlagSet("", flag.ContinueOnError) | |||
|
|
|||
| fs.String(FlagDuration, "86400s", "The duration token to be locked. e.g. 1h, 1m, 1s, 0.1s") | |||
| fs.String(FlagDuration, "86400s", "The duration token to be locked. e.g. 86400s, 604800s, 1209600s") | |||
There was a problem hiding this comment.
Can we put these in hours? I believe thats the largest default unit supported by golang
ValarDragon
approved these changes
Feb 13, 2022
czarcas7ic
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2022
* min duration from 1d to 24h (d not recognized), changed weekly to day (weekly doesnt work, only week) * changed from seconds to hours (cherry picked from commit e4e97a3)
ValarDragon
pushed a commit
that referenced
this pull request
Feb 14, 2022
* min duration from 1d to 24h (d not recognized), changed weekly to day (weekly doesnt work, only week) * changed from seconds to hours (cherry picked from commit e4e97a3) Co-authored-by: Adam Tucker <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two queries
osmosisd query lockup total-locked-of-denom gamm/pool/1Wont work since it tries to use
1das default min duration. Changed default to 86400s.osmosisd query epochs current-epoch -hShows weekly as a potential input but its week not weekly. While I was at it I just changed default to day since it is most used.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer