Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade iavl and sdk with fast storage #846

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Upgrade iavl and sdk with fast storage #846

merged 4 commits into from
Feb 11, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Feb 11, 2022

Closes: #XXX

Background
This release introduces an upgrade of iavl and the SDK with fast storage implementation that represents a copy of the latest version of the tree with performance improvements. The fast storage nodes are indexed by key on disk as opposed to by hash with the original tree implementation. It allows us to preserve data locality for the latest state, significantly improving iterations and queries. This implementation introduces a negligible overhead for writes.

Downgrade-re-upgrade protection
We introduced a downgrade and re-upgrade protection where we guard for potential downgrades of iavl and the subsequent enablement of the fast storage again. This is done so by storing the metadata about the current version of the storage and the latest live state stored.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@p0mvn p0mvn requested a review from ValarDragon February 11, 2022 19:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v6.x@c709aac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v6.x     #846   +/-   ##
=======================================
  Coverage        ?   19.06%           
=======================================
  Files           ?      167           
  Lines           ?    23684           
  Branches        ?        0           
=======================================
  Hits            ?     4516           
  Misses          ?    18387           
  Partials        ?      781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c709aac...9304f6c. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ValarDragon ValarDragon merged commit 846194d into v6.x Feb 11, 2022
@ValarDragon ValarDragon deleted the roman/v6.x-fast branch February 11, 2022 19:47
@hleb-albau
Copy link
Contributor

WOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants