Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Speedup one JSON unmarshal (backport #8398) #8399

Closed
wants to merge 6 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 17, 2024

Speedup one JSON unmarshal being hit in production codepath


This is an automatic backport of pull request #8398 done by Mergify.

* Speedup one JSON unmarshal

* Update changelog

(cherry picked from commit 837b58c)

# Conflicts:
#	x/ibc-rate-limit/ibc_module.go
Copy link
Contributor Author

mergify bot commented Jun 17, 2024

Cherry-pick of 837b58c has failed:

On branch mergify/bp/v25.x/pr-8398
Your branch is up to date with 'origin/v25.x'.

You are currently cherry-picking commit 837b58c3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/ibc-rate-limit/ibc_module.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@czarcas7ic
Copy link
Member

@ValarDragon I don't think e2e is happy with this change on v25.x, I have run it a few times now

@PaddyMc
Copy link
Collaborator

PaddyMc commented Jul 3, 2024

discussed with @ValarDragon closing and will be included in v26 instead

@PaddyMc PaddyMc closed this Jul 3, 2024
@mergify mergify bot deleted the mergify/bp/v25.x/pr-8398 branch July 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants