Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Slow down action run time by reducing concurrent operations #8272

Merged
merged 1 commit into from
May 17, 2024

Conversation

deividaspetraitis
Copy link
Contributor

Closes: #7877

What is the purpose of the change

This pull request slows down "check broken links" action by reducing concurent requests to 1 ( default: 128 ).
After this change action will take around 10mins to complete for 1.5k links at the moment ( previously 30sec ) with no failed requests as per testing.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? No
  • Changelog entry added to Unreleased section of CHANGELOG.md? No

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@deividaspetraitis deividaspetraitis requested a review from a team as a code owner May 16, 2024 13:13
Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

The recent change in the .github/workflows/check-broken-links.yml file involves adding the --max-concurrency 1 argument to the lychee-action step. This adjustment aims to prevent the link-checking process from being rate-limited by reducing the number of simultaneous requests.

Changes

File Change Summary
.github/workflows/check-broken-links.yml Added --max-concurrency 1 argument to the lychee-action step to limit concurrency and avoid rate limiting.

Assessment against linked issues

Objective Addressed Explanation
Prevent the broken links job from being rate limited (#7877)
Ensure the job detects broken links instead of getting rate limited (#7877)

Poem

In the realm of links, we tread with care,
One by one, no rush, no snare.
Concurrency tamed, no more rate limit fright,
Our broken links job now works just right.
🌐🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 84c6ac2 and efb3511.
Files selected for processing (1)
  • .github/workflows/check-broken-links.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/check-broken-links.yml (1)

30-30: The addition of --max-concurrency 1 is correct and aligns with the PR objectives to reduce rate limiting issues by limiting concurrent requests. This change should help in avoiding rate limiting errors as described in the PR summary.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the T:CI label May 16, 2024
@deividaspetraitis
Copy link
Contributor Author

hey @czarcas7ic, I was wondering is it expected that this PR has no reviewers assigned, since in the last one there was several reviewers.

Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@czarcas7ic czarcas7ic merged commit 003dceb into osmosis-labs:main May 17, 2024
1 check passed
@deividaspetraitis deividaspetraitis deleted the 7877 branch May 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Links Job Gets Rate Limited
2 participants