Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add circuit breaker controller to smartaccount module #8216

Merged
merged 2 commits into from
May 3, 2024

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented May 3, 2024

What is the purpose of the change

  • adding the daodao contract to the circuit breaker controller to the smart account params

https://daodao.zone/dao/osmo1wn58hxkv0869ua7qmz3gvek3sz773l89a778fjqvenl6anwuhgnq6ks7kl/home

@PaddyMc PaddyMc added V:state/breaking State machine breaking PR A:backport/v25.x backport patches to v25.x branch labels May 3, 2024
Copy link
Contributor

coderabbitai bot commented May 3, 2024

Walkthrough

This update introduces new constants and updates existing parameters in the system's authentication and control mechanisms. It involves the addition of limits on unauthenticated gas usage, activation flags for smart accounts, and the inclusion of a new controller for circuit breakers. Additionally, it enhances testing to ensure these changes are correctly integrated and functioning as expected post-upgrade.

Changes

File Path Change Summary
.../v25/constants.go Added new constants and updated existing values for block age and duration.
.../v25/upgrades.go Updated authenticatorParams with new constants and appended new controller to CircuitBreakerControllers.
.../v25/upgrades_test.go Enhanced tests to include checks for new smart account parameters and post-upgrade consensus parameters.

🐇💻
A hop, a skip, a code deploy,
In the warren, tech joy!
Constants new, parameters tune,
Under the silvery moon.
Let's celebrate, for the upgrade's boon! 🌕🎉


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0bb45e7 and 68a5ae6.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label May 3, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (9)
CHANGELOG.md (9)

Line range hint 1023-1023: Ensure heading levels increment by one level at a time.

- ### [v6.4.0]
+ ## [v6.4.0]

Line range hint 1035-1035: Ensure heading levels increment by one level at a time.

- ### [v6.3.1]
+ ## [v6.3.1]

Line range hint 1044-1044: Ensure heading levels increment by one level at a time.

- ### [v6.3.0]
+ ## [v6.3.0]

Line range hint 1049-1049: Ensure heading levels increment by one level at a time.

- ### [v6.2.0]
+ ## [v6.2.0]

Line range hint 1101-1101: Ensure heading levels increment by one level at a time.

- ### [v6.0.0]
+ ## [v6.0.0]

Line range hint 362-362: Remove trailing punctuation in heading.

- ## [v4.0.0]
+ ## [v4.0.0]

Line range hint 625-625: Avoid using bare URLs. Provide a descriptive link text.

- * [sdk-#100](https://github.com/osmosis-labs/cosmos-sdk/pull/100) Upgrade iavl with fast storage
+ * [Upgrade iavl with fast storage](https://github.com/osmosis-labs/cosmos-sdk/pull/100)

Line range hint 683-683: Avoid using bare URLs. Provide a descriptive link text.

- * [iavl-5](https://github.com/osmosis-labs/iavl/pull/5) Fast storage optimization for queries and iterations
+ * [Fast storage optimization for queries and iterations](https://github.com/osmosis-labs/iavl/pull/5)

Line range hint 1264-1264: Ensure there are no empty links in the document.

- * [sdk-#58](https://github.com/osmosis-labs/cosmos-sdk/pull/58) Fix a bug where recheck would not remove txs with invalid sequence numbers
+ * [Fix a bug where recheck would not remove txs with invalid sequence numbers](https://github.com/osmosis-labs/cosmos-sdk/pull/58)

@PaddyMc PaddyMc merged commit f322111 into main May 3, 2024
1 check passed
@PaddyMc PaddyMc deleted the feat/add-dao-dao-contract-to-sa-params branch May 3, 2024 11:24
mergify bot pushed a commit that referenced this pull request May 3, 2024
* fix: add circuit breaker controller to smartaccount module

* chore: adding changelog

(cherry picked from commit f322111)
PaddyMc added a commit that referenced this pull request May 3, 2024
…8217)

* fix: add circuit breaker controller to smartaccount module

* chore: adding changelog

(cherry picked from commit f322111)

Co-authored-by: PaddyMc <[email protected]>
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v25.x backport patches to v25.x branch C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants