-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate app.go #795
Annotate app.go #795
Conversation
This is nice to explain to people how it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once suggested comment change is in! ( I don't have perms to push to the branch)
Thanks for adding this, should help onboarding!
Co-authored-by: Dev Ojha <[email protected]>
Onboarding is gonna be an ecosystem-wide team effort.... |
Codecov Report
@@ Coverage Diff @@
## sunny/sdk-v0.45 #795 +/- ##
================================================
Coverage 19.96% 19.96%
================================================
Files 189 189
Lines 24542 24542
================================================
Hits 4900 4900
Misses 18787 18787
Partials 855 855 Continue to review full report at Codecov.
|
Wait what, why did merging sunny's PR close this, I thought github auto-updates PRs to re-target main >:( |
I don't have perms to reopen off your fork |
hey no worries-- I'll push to osmosis-labs in the future and resubmit :) |
Closes: #XXX
Description
While building Craft Economy and trying to become more familiar with the cosmos SDK, and familiarize others, I ended up annotating app.go, and found it really helpful, so I figured that I might as well annotate Osmosis' app.go, too!
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer