Remove an extra argument from crossTick

[ValarDragon]

Small followup from #7689

Summary by CodeRabbit

• Refactor
  • Simplified error handling in liquidity operations.
  • Streamlined return values in cross-tick functions to enhance clarity and efficiency.

[coderabbitai]

Walkthrough

The modifications primarily revolve around the simplification of the crossTick function's return signature across several files in the concentrated liquidity module. The liquidityDelta return value was removed, streamlining the function to only return an error. This change necessitates adjustments in error handling and the way functions that call crossTick manage its return value, reflecting a more focused approach to error management and function output.

Changes

Files	Change Summary
.../export_test.go, .../tick.go	Simplified crossTick function return signature by removing liquidityDelta, now only returns err.
.../keeper_test.go, .../swaps.go, .../tick_test.go	Adjusted function calls and error handling to align with the new crossTick return signature.

🐇✨
Changes in the code, like leaves in the fall,
Simplify, clarify, one error fits all.
No more delta to chase, in the tick's gentle call,
Just a hop, skip, and a jump, over bugs big and small.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f8d711 and 811f31b.

Files selected for processing (5)

• x/concentrated-liquidity/export_test.go (1 hunks)
• x/concentrated-liquidity/keeper_test.go (1 hunks)
• x/concentrated-liquidity/swaps.go (1 hunks)
• x/concentrated-liquidity/tick.go (2 hunks)
• x/concentrated-liquidity/tick_test.go (1 hunks)

Check Runs (9)

osmosisd-linux-arm64 completed (1)

osmosisd-darwin-arm64 completed (1)

osmosisd-linux-amd64 completed (1)

get_diff completed (2)

osmosisd-darwin-amd64 completed (1)

Run golangci-lint completed (1)

test completed (1)

Run super-linter completed (1)

Check Actions completed (2)

Additional comments: 5

x/concentrated-liquidity/tick.go (1)

• 65-73: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [68-96]

The changes to the crossTick function, specifically the removal of the liquidityDelta return value, align with the PR's objective to simplify the function's interface. This should streamline the module's functionality without compromising its correctness.

However, it's crucial to verify the broader impact of this change on the module's behavior and ensure that all dependent functions and modules are updated accordingly.

x/concentrated-liquidity/export_test.go (1)

• 47-47: The update to the CrossTick function's signature in export_test.go, removing the liquidityDelta osmomath.Dec return value, is consistent with the changes made in tick.go. This ensures uniformity across the module's codebase.

It's important to verify that all test cases and any dependent code have been updated to reflect this change, ensuring that the module's functionality remains correct and consistent.

x/concentrated-liquidity/keeper_test.go (1)

• 383-383: The modification to the CrossTick function call aligns with the PR's objective of simplifying the function's interface by removing an unnecessary return value. Ensure that the test logic surrounding this call remains valid and comprehensive after this change.

x/concentrated-liquidity/tick_test.go (1)

• 676-677: The assignment of liquidityDelta directly from nextTickInfo.LiquidityNet after calling CrossTick is a significant change reflecting the PR's objective to simplify the CrossTick function by removing an unnecessary return value. This change aligns with the PR's goal to streamline the function's interface and potentially its internal logic. However, it's crucial to ensure that all references to liquidityDelta in the codebase are updated accordingly to prevent any unintended behavior or errors due to this change.

x/concentrated-liquidity/swaps.go (1)

• 688-688: The change in error handling within the swapCrossTickLogic function aligns with the PR's objective to streamline functionality by simplifying the CrossTick function's interface. However, it's crucial to ensure that this adjustment does not inadvertently affect the error handling logic elsewhere in the module or introduce potential issues with error propagation.

Ensure that the modified error handling in swapCrossTickLogic does not impact other parts of the module negatively or introduce new error handling inconsistencies.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 811f31b and 62b70ac.

Files selected for processing (1)

• x/concentrated-liquidity/tick_test.go (1 hunks)

Check Runs (9)

osmosisd-linux-arm64 completed (1)

osmosisd-darwin-arm64 completed (1)

osmosisd-linux-amd64 completed (1)

get_diff completed (2)

osmosisd-darwin-amd64 completed (1)

Run golangci-lint completed (1)

Run super-linter completed (1)

Check Actions completed (2)

test completed (1)

Files skipped from review as they are similar to previous changes (1)

• x/concentrated-liquidity/tick_test.go