-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unblock ww pools #7716
feat: unblock ww pools #7716
Conversation
WalkthroughThe recent changes focus on refining the handling of pool data, particularly for CosmWasm pools. This includes introducing a new import for better management of CosmWasm pool types, removing references to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ingest/sqs/pools/ingester/pool_ingester.go (3 hunks)
Additional comments: 2
ingest/sqs/pools/ingester/pool_ingester.go (2)
- 16-16: The addition of the
cosmwasmpooltypes
import aligns with the PR's objective to better handle CosmWasm pools, specifically the White Whale pools. This import is crucial for the integration and accurate balance assessment of these pools. Ensure that this new dependency is properly managed and versioned to avoid potential compatibility issues.- 323-330: The logic to handle CosmWasm pools by casting them to
cosmwasmpooltypes.CosmWasmExtension
and obtaining their total liquidity directly is a significant improvement. This change directly addresses the issue of inaccurately assessing pool balances by relying on bank balances rather than the actual liquidity in the pools. However, ensure that theGetTotalPoolLiquidity
method is robust and handles potential edge cases or errors gracefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- ingest/sqs/pools/ingester/pool_ingester.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- ingest/sqs/pools/ingester/pool_ingester.go
(cherry picked from commit 6a97c26)
(cherry picked from commit 6a97c26)
Closes: #XXX
What is the purpose of the change
White whale pools are not picked up by the router due to being blackisted because of a recent breakage.
Now that the pools are migrated, we bring them back.
The pool balances are also not picked up due to reading bank balances as opposed to liquidity from the pool itself. This PR fixes it.
Summary by CodeRabbit
CosmWasm
pool types, enhancing compatibility and data processing efficiency.