Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmwasm pool model code ID migration #7595

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Feb 22, 2024

Closes: #XXX

What is the purpose of the change

Found when testing white whale pool migration on testnet.

We did not update the cw pool model in the state machine.

There should be no serious impact but if pools are migrated using this method today, we would have to maintain old code IDs in the whitelist until the state is fixed via the upgrade handler

Testing and Verifying

  • Unit tests
  • Testnet

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Feb 22, 2024
@p0mvn p0mvn closed this Feb 22, 2024
@p0mvn p0mvn reopened this Feb 22, 2024
@p0mvn p0mvn marked this pull request as ready for review February 23, 2024 00:13
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@p0mvn p0mvn merged commit a84bdc4 into main Feb 23, 2024
1 check passed
@p0mvn p0mvn deleted the roman/fix-cw-pool-migration branch February 23, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants