Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup CL: TickToPrice #7539

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Speedup CL: TickToPrice #7539

merged 3 commits into from
Feb 19, 2024

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Feb 19, 2024

Some quick speedups to CL's TickToPrice and PriceToTick. We need to update the osmomath version to get the more significant speedups in backports.

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v22.x backport patches to v22.x branch A:backport/v23.x backport patches to v23.x branch labels Feb 19, 2024
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/concentrated-liquidity/math/tick.go Outdated Show resolved Hide resolved
@@ -8,6 +8,8 @@ import (
"github.com/osmosis-labs/osmosis/v23/x/concentrated-liquidity/types"
)

var maxSpotPriceBigDec = osmomath.BigDecFromDec(types.MaxSpotPrice)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's move this to types

@ValarDragon ValarDragon merged commit a80c00e into main Feb 19, 2024
1 check passed
@ValarDragon ValarDragon deleted the dev/speedup_ticktoprice branch February 19, 2024 14:32
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
* Speedup CL: TickToPrice

* Speedup PriceToTick

* Address Matt's comment

(cherry picked from commit a80c00e)
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
* Speedup CL: TickToPrice

* Speedup PriceToTick

* Address Matt's comment

(cherry picked from commit a80c00e)
ValarDragon added a commit that referenced this pull request Feb 19, 2024
* Speedup CL: TickToPrice

* Speedup PriceToTick

* Address Matt's comment

(cherry picked from commit a80c00e)

Co-authored-by: Dev Ojha <[email protected]>
ValarDragon added a commit that referenced this pull request Feb 20, 2024
* Speedup CL: TickToPrice

* Speedup PriceToTick

* Address Matt's comment

(cherry picked from commit a80c00e)

Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v22.x backport patches to v22.x branch A:backport/v23.x backport patches to v23.x branch A:no-changelog C:x/concentrated-liquidity V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants