-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(protorev): base denom as param #7508
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f86211a
base denom protorev param performance change
czarcas7ic 072eafc
register param and fix tests
czarcas7ic d9b489a
delete old KVStore values in the upgrade handler
czarcas7ic 1297bec
add changelog entry
czarcas7ic 0b723b4
remove BaseDenom from genState
czarcas7ic 96f9716
clean approach in upgrade handler
czarcas7ic e7e9d2e
clean up
czarcas7ic 6f5e02c
Revert "clean up"
czarcas7ic 7bf614e
Revert "clean approach in upgrade handler"
czarcas7ic 7ade80a
Revert "remove BaseDenom from genState"
czarcas7ic f213ec1
Revert "add changelog entry"
czarcas7ic 22feaf0
Revert "delete old KVStore values in the upgrade handler"
czarcas7ic 50fd552
Revert "register param and fix tests"
czarcas7ic 3277798
Revert "base denom protorev param performance change"
czarcas7ic fe56a0f
Merge branch 'main' into adam/base-denom-param-perf
czarcas7ic 25f47d8
protorev perf non param
czarcas7ic 8bd740a
remove deprecated delete
czarcas7ic 489002c
reset proto
czarcas7ic 13e0c32
final cleanups
czarcas7ic bff8cb1
quick test fix
czarcas7ic a838fc1
reserve pool_weights proto field
czarcas7ic a71d477
Merge branch 'main' into adam/base-denom-param-perf
czarcas7ic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to delete the base denoms since we overwrite the single BaseDenoms value.