[performance]: Better key formatting in taker fee #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
mattverse
approved these changes
Feb 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit a767fab)
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit a767fab)
czarcas7ic
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit a767fab) Co-authored-by: Dev Ojha <[email protected]>
czarcas7ic
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit a767fab) Co-authored-by: Dev Ojha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A driveby fix for improving the key formatting of taker fee keys. I was surprised to see this was taking .1% of state machine exec time. (Mostly due to too many calls w/ protorev, but still shocking regardless)
This just lowers the heap allocs here.