722 reuse code for parsing integer slices from string #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Jan 10, 2022
p0mvn
reviewed
Jan 10, 2022
p0mvn
reviewed
Jan 10, 2022
p0mvn
reviewed
Jan 10, 2022
|
Thanks @akhtariev, your comment make a lot of sense here! I'm going to change that |
ValarDragon
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Thanks @iButcat and @akhtariev for writing and reviewing this 🙏
Codecov Report
@@ Coverage Diff @@
## main #747 +/- ##
=======================================
Coverage 18.73% 18.73%
=======================================
Files 172 172
Lines 23908 23896 -12
=======================================
Hits 4478 4478
+ Misses 18655 18643 -12
Partials 775 775
Continue to review full report at Codecov.
|
ValarDragon
pushed a commit
that referenced
this pull request
Jan 13, 2022
* remove repeted code to create a function from it * create function Parse Uint64 Slice From String * replace repeted code with function made for it * changelog add modification * resolve style requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #722
Description
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer