[Uptime Incentives]: Add test cases that demonstrate proper handling of existing inconsistent NoLock gauge state
#7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlpinYukseloglu
added
V:state/compatible/no_backport
p0mvn
approved these changes
Feb 7, 2024
p0mvn
approved these changes
Feb 7, 2024
p0mvn
pushed a commit
that referenced
this pull request
Feb 8, 2024
…of existing inconsistent `NoLock` gauge state (#7420) * implement validation, fallback, and wiring for using gauge duration as uptime * add changelog * add param into core CL distr logic and set up sanity tests * use new param in core logic and add tests * clean up internal gauge distribution tests * attempt to clean up diff * add changelog * add test cases that cover handling of existing inconsistent state * extract uptime fetch into helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7375
What is the purpose of the change
Please see issue for discussion on the problem being considered. This PR demonstrates that the design decisions made in previous PRs make it so the hacky/inconsistent state described in the issue is handled elegantly without any state-dependent branches.
Testing and Verifying
This PR adds test cases to
distribute_test.goDocumentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)