Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IBC to emit errors as events #7400

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

cosmos/ibc-go#5541 has been released. This is something we've been needing for a while so that we can provide proper errors to users of ibc hooks.

Testing and Verifying

Added a check on an existing test that shows the event being emitted.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@nicolaslara nicolaslara added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks and removed C:x/epochs labels Feb 1, 2024
@nicolaslara nicolaslara merged commit 6705b46 into main Feb 2, 2024
1 check passed
@nicolaslara nicolaslara deleted the nicolas/ibc-error-events branch February 2, 2024 09:02
Comment on lines +387 to +388
// cometbft is replaced to print custom app hash logs. Using branch nicolas/v0.37.4-v23-osmo-1. Need to tag this before releasing
github.com/cometbft/cometbft => github.com/osmosis-labs/cometbft v0.0.0-20240201155058-95b5f9262e1d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all for the comment change, but this has already been merged

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v23.x backport patches to v23.x branch and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Feb 12, 2024
mergify bot pushed a commit that referenced this pull request Feb 12, 2024
* update IBC to emit errors as events

* changelog

(cherry picked from commit 6705b46)

# Conflicts:
#	go.mod
#	go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.sum
#	x/ibc-hooks/go.sum
p0mvn added a commit that referenced this pull request Feb 12, 2024
p0mvn added a commit that referenced this pull request Feb 12, 2024
p0mvn added a commit that referenced this pull request Feb 12, 2024
p0mvn added a commit that referenced this pull request Feb 12, 2024
* Update IBC to emit errors as events (backport #7400)

* updates

---------

Co-authored-by: Roman <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants