Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update wasm vm as per CWA-2023-004 #7300

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Jan 11, 2024

Closes: #XXX

What is the purpose of the change

As per CWA-2023-004, bump wasmvm version from v1.5.0 to v1.5.1

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v22.x backport patches to v22.x branch labels Jan 11, 2024
@czarcas7ic czarcas7ic changed the title fix: update wasm vm fix: update wasm vm as per CWA-2023-004 Jan 11, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review January 11, 2024 00:58
@czarcas7ic
Copy link
Member Author

This update has failed e2e 3 times in a row

PaddyMc
PaddyMc previously approved these changes Jan 11, 2024
@mattverse
Copy link
Member

Double checked, this is the only PR that's making e2e fail rn 🤔

@PaddyMc PaddyMc self-requested a review January 11, 2024 11:49
@PaddyMc PaddyMc dismissed their stale review January 11, 2024 11:49

mistake

@PaddyMc
Copy link
Collaborator

PaddyMc commented Jan 11, 2024

e2e tests passed after being re-run 🥲

@mattverse
Copy link
Member

mattverse commented Jan 11, 2024

@PaddyMc Yep, but super flaky. I've ran it multiple times myself, but fails at the same point when its failing, which is a little sus

@czarcas7ic
Copy link
Member Author

Going to merge the E2E change and then merge that into this PR and determine if we were just unlucky or if this PR actually makes a change that modifies logic negatively

@czarcas7ic czarcas7ic merged commit 11f1873 into main Jan 12, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/update-wasm-vm branch January 12, 2024 03:54
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
* update wasm vm

* update changelog

* spacing

(cherry picked from commit 11f1873)
czarcas7ic added a commit that referenced this pull request Jan 12, 2024
* update wasm vm

* update changelog

* spacing

(cherry picked from commit 11f1873)

Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v22.x backport patches to v22.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants