Remove using an iterator from updating TWAP records #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
mattverse
reviewed
Jan 8, 2024
| @@ -151,6 +151,23 @@ func (k Keeper) GetAllMostRecentRecordsForPool(ctx sdk.Context, poolId uint64) ( | |||
| return types.GetAllMostRecentTwapsForPool(store, poolId) | |||
| } | |||
|
|
|||
| // GetAllMostRecentRecordsForPool returns all most recent twap records | |||
| // (in state representation) for the provided pool id. | |||
| func (k Keeper) GetAllMostRecentRecordsForPoolWithDenoms(ctx sdk.Context, poolId uint64, denoms []string) ([]types.TwapRecord, error) { | |||
There was a problem hiding this comment.
Can we have unit test for this method?
mattverse
reviewed
Jan 8, 2024
| // (in state representation) for the provided pool id. | ||
| func (k Keeper) GetAllMostRecentRecordsForPoolWithDenoms(ctx sdk.Context, poolId uint64, denoms []string) ([]types.TwapRecord, error) { | ||
| store := ctx.KVStore(k.storeKey) | ||
| // if length != 2, use iterator |
|
I think we should add changelog for this, but is soft suggestion |
czarcas7ic
approved these changes
Jan 8, 2024
p0mvn
approved these changes
Jan 8, 2024
Comment on lines
+95
to
+99
| func GetMostRecentTwapForPool(store sdk.KVStore, poolId uint64, denom1, denom2 string) (TwapRecord, error) { | ||
| key := FormatMostRecentTWAPKey(poolId, denom1, denom2) | ||
| bz := store.Get(key) | ||
| return ParseTwapFromBz(bz) | ||
| } |
There was a problem hiding this comment.
nit: would it be better to have this within keeper since it touches store?
There was a problem hiding this comment.
I think having this here makes sense given prev code structure (e.g GetAllMostRecentTwapsForPool also lives in types/keys.go)
|
Agree about the unit test |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
Added unit tests, will be merging this PR by EOW |
czarcas7ic
approved these changes
Jan 30, 2024
|
Thank you for adding the test 🙏 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Remove using an iterator from updating TWAP records * Changelog * Add test case --------- Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9193ee4) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Remove using an iterator from updating TWAP records * Changelog * Add test case --------- Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9193ee4)
ValarDragon
added a commit
that referenced
this pull request
Feb 2, 2024
* Remove using an iterator from updating TWAP records * Changelog * Add test case --------- Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9193ee4) Co-authored-by: Dev Ojha <[email protected]>
p0mvn
pushed a commit
that referenced
this pull request
Feb 3, 2024
…7403) * Remove using an iterator from updating TWAP records (#7266) * Remove using an iterator from updating TWAP records * Changelog * Add test case --------- Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9193ee4) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Dev Ojha <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows up in benchmarks as being a slowdown on getting TWAP records. It will affect gas, but should only do so in EndBlock logic which should not be gas metered.
We see this iterator call being the cause of around .4% of State machine processing speed and even persists in the IAVL v2 benchmarks as a real expense.