Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change in_denom to out_denom #7245

Merged
merged 2 commits into from
Jan 7, 2024
Merged

fix: change in_denom to out_denom #7245

merged 2 commits into from
Jan 7, 2024

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Jan 4, 2024

No description provided.

@mattverse mattverse added the V:state/breaking State machine breaking PR label Jan 5, 2024
@mattverse
Copy link
Member

@Halimao Thanks for the PR! Can we get a changelog entry for this?

@Halimao
Copy link
Contributor Author

Halimao commented Jan 5, 2024

@Halimao Thanks for the PR! Can we get a changelog entry for this?

Addressed～

czarcas7ic
czarcas7ic approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR! :)

@czarcas7ic
Copy link
Member

Fairly sure its state compat but just going to merge to main for simplicity

@czarcas7ic czarcas7ic merged commit 647904f into osmosis-labs:main Jan 7, 2024
1 check passed
@Halimao Halimao deleted the fix/wrong-json-tag branch January 7, 2024 02:41
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
C:x/poolmanager V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Halimao @mattverse @czarcas7ic