Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: charge gas when querying cw contracts #7209

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Dec 25, 2023

Closes: #XXX

What is the purpose of the change

In cosmwasm query helper, we missed charging gas on the parent context. Without this change, the parent context does not have gas charged in case of successful query. This PR fixes it.

Testing and Verifying

  • Added unit test

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Dec 25, 2023
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@p0mvn p0mvn marked this pull request as ready for review December 26, 2023 00:21
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high level ACK

@p0mvn p0mvn merged commit 370b381 into main Jan 9, 2024
1 check passed
@p0mvn p0mvn deleted the roman/gas-meter-fix-cw-query branch January 9, 2024 19:53
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants