Reduce sprintf overhead in code showing up during sync profiles #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
nicolaslara,
p0mvn,
AlpinYukseloglu,
czarcas7ic and
mattverse
as code owners
ValarDragon
added
V:state/compatible/backport
nicolaslara
reviewed
Dec 22, 2023
x/poolmanager/types/keys.go
Outdated
| @@ -43,7 +44,16 @@ var ( | |||
|
|
|||
| // ModuleRouteToBytes serializes moduleRoute to bytes. | |||
| func FormatModuleRouteKey(poolId uint64) []byte { | |||
| return []byte(fmt.Sprintf("%s%d", SwapModuleRouterPrefix, poolId)) | |||
| // Estimate the length of the string representation of poolId | |||
| // 7 is a safe upper bound, (9999999) pools, and is an 8 byte allocation (not bad) | |||
There was a problem hiding this comment.
just for extra safety... should we check that poolId < 9999999?
There was a problem hiding this comment.
All we could really do is panic, which is what will already happen here anyway
There was a problem hiding this comment.
We can add that check to CreatePool
There was a problem hiding this comment.
Ok just raised the upperbound to 99,999,999,999. At $1 to create a pool, this is a third the market cap of ETH, so going to go ahead and merge!
|
Added check for it in #7203 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 24, 2023
* Reduce sprintf overhead in code showing up during sync profiles * Raise upperbound to not worry about it (cherry picked from commit cb9cb4e)
ValarDragon
added a commit
that referenced
this pull request
Dec 24, 2023
… (#7204) * Reduce sprintf overhead in code showing up during sync profiles * Raise upperbound to not worry about it (cherry picked from commit cb9cb4e) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Dec 24, 2023
… (#7204) * Reduce sprintf overhead in code showing up during sync profiles * Raise upperbound to not worry about it (cherry picked from commit cb9cb4e) Co-authored-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce some sprintf overheads
This is a pretty micro-optimization. It likely has more impact for txs than epoch. In epoch it shaves like 100ms (there are way better things to shave time on there)