Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace MinCoins with sdk coins.Min() #7127

Merged
merged 5 commits into from
Jan 1, 2024

Conversation

levisyin
Copy link
Contributor

@levisyin levisyin commented Dec 15, 2023

What is the purpose of the change

MinCoins could be replaced by coins.Min(), this PR replaces all reference of using MinCoins to coins.Min()

@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:simulator Edits simulator or simulations labels Dec 15, 2023
@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Dec 15, 2023
@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v20.x backport patches to v20.x branch A:backport/v21.x backport patches to v21.x branch and removed A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Dec 15, 2023
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking these changes :) LGTM

@levisyin
Copy link
Contributor Author

Hi @mattverse sir, is there anything else need I to add or can we get this merged😀

@levisyin
Copy link
Contributor Author

@p0mvn Hi sir, can we get this merged😀

@czarcas7ic czarcas7ic added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks and removed A:backport/v20.x backport patches to v20.x branch A:backport/v21.x backport patches to v21.x branch V:state/compatible/backport State machine compatible PR, should be backported labels Jan 1, 2024
@czarcas7ic czarcas7ic merged commit ccd1865 into osmosis-labs:main Jan 1, 2024
1 check passed
@mattverse mattverse added the A:backport/v21.x backport patches to v21.x branch label Jan 9, 2024
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
* refactor: replace MinCoins with sdk coins.Min()

* fix: remove unused import

(cherry picked from commit ccd1865)

# Conflicts:
#	osmoutils/coin_helper.go
p0mvn pushed a commit that referenced this pull request Jan 9, 2024
* refactor: replace MinCoins with sdk coins.Min() (#7127)

* refactor: replace MinCoins with sdk coins.Min()

* fix: remove unused import

(cherry picked from commit ccd1865)

# Conflicts:
#	osmoutils/coin_helper.go

* Fix merge conflict

---------

Co-authored-by: levisyin <[email protected]>
Co-authored-by: mattverse <[email protected]>
@levisyin levisyin deleted the refactor/replace-MinCoins branch January 25, 2024 04:21
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v21.x backport patches to v21.x branch A:no-changelog C:simulator Edits simulator or simulations C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants