Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using coins.Denoms() from sdk instead of osmoutils #7126

Merged
merged 1 commit into from
Dec 15, 2023
Merged

refactor: using coins.Denoms() from sdk instead of osmoutils #7126

merged 1 commit into from
Dec 15, 2023

Conversation

levisyin
Copy link
Contributor

Complete TODO of CoinsDenoms. I have replaced all reference using with coins.Denoms()

// TODO: Get this into the SDK https://github.com/cosmos/cosmos-sdk/issues/12538
func CoinsDenoms(coins sdk.Coins) []string {
	denoms := make([]string, len(coins))
	for i, coin := range coins {
		denoms[i] = coin.Denom
	}
	return denoms
}

@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:simulator Edits simulator or simulations C:x/twap Changes to the twap module labels Dec 15, 2023
mattverse
mattverse approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! LGTM

@mattverse mattverse added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Dec 15, 2023
@mattverse mattverse merged commit 7419314 into osmosis-labs:main Dec 15, 2023
1 check passed
@levisyin levisyin deleted the refactor/using-sdk-coins2denom branch December 15, 2023 07:43
@mattverse mattverse added the A:backport/v21.x backport patches to v21.x branch label Jan 9, 2024
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@levisyin @mergify
refactor: using coins.Denoms() from sdk instead of osmoutils (#7126)
28a8bc1 
(cherry picked from commit 7419314)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Merged
mattverse pushed a commit that referenced this pull request Jan 9, 2024
@mergify @levisyin
refactor: using coins.Denoms() from sdk instead of osmoutils (#7126) (#…
b45ba13 
…7277)

(cherry picked from commit 7419314)

Co-authored-by: levisyin <[email protected]>
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

Assignees
No one assigned
Labels
A:backport/v21.x backport patches to v21.x branch A:no-changelog C:simulator Edits simulator or simulations C:x/gamm Changes, features and bugs related to the gamm module. C:x/twap Changes to the twap module V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levisyin @mattverse