Speedup log2 code #7106
Merged
Speedup log2 code #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
pysel
approved these changes
Dec 13, 2023
ValarDragon
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2)
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2)
This was referenced Dec 13, 2023
p0mvn
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2) Co-authored-by: Dev Ojha <[email protected]>
p0mvn
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Dec 22, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Dec 22, 2023
* Speedup log2 code * Update changelog (cherry picked from commit fc3ccf2) Co-authored-by: Dev Ojha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State compatible logic to speedup the Log base 2 code, which appears in TWAPs.
This causes CPU usage for many wasm contracts, and EndBlock in updating TWAPs. Will further work to having this get computed when interpolating records for arithmetic TWAPs.
This PR takes the log2 code on my machine from:
to
So almost halving the CPU time, halving the I/O writes, and drastically reducing the number of allocs!
Not seeing any other obvious wins, beyond changing data type/algorithm as the bottleneck is now mulmut