Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SQS): app wiring and config v20.x #6965

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Nov 30, 2023

Closes: #XXX

What is the purpose of the change

Cleaning up app wiring and configuring sqs from file as opposed to env variables

Tested locally

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Nov 30, 2023
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@p0mvn p0mvn force-pushed the roman/sqs-v20-app-wiring branch from 45e525e to 68110dc Compare November 30, 2023 22:56
@p0mvn p0mvn changed the title refactor(SQS): app wiring and config refactor(SQS): app wiring and config v20.x Nov 30, 2023
@p0mvn p0mvn marked this pull request as ready for review December 1, 2023 20:13
@p0mvn p0mvn requested a review from a team as a code owner December 1, 2023 20:13
@p0mvn p0mvn merged commit a99eabd into roman/sqs-poc-v20 Dec 1, 2023
1 check passed
@p0mvn p0mvn deleted the roman/sqs-v20-app-wiring branch December 1, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder T:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant