fix: total liquidity poolmanager grpc gateway query #6944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLieu
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
|
Which PR I don't pass the proto gene because:: |
|
@DongLieu Don't worry about the proto gen for now, can get it up to date after merge. However, can you take a look and fix the sync issue between Notional's repo <> main repo? |
|
Ok |
|
I usually checkout from the main osmosis repo and never use the main of notional |
pysel
approved these changes
Dec 1, 2023
|
@DongLieu Can you merge this with most recent main? once done, will go ahead and merge this PR |
6 tasks
|
I would like to close this PR, because I no longer work in notional so I can't merge the main @mattverse check it out in PR #6991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6941
What is the purpose of the change
(E.g.: This pull request improves documentation of area A by adding ....
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)