Add healthcheck endpoint to sqs #6935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Nov 29, 2023
ingest/sqs/chain_info/repository/redis/redis_chain_info_repository.go
Outdated
Show resolved
Hide resolved
Comment on lines
+79
to
+83
| Result struct { | ||
| SyncInfo struct { | ||
| LatestBlockHeight string `json:"latest_block_height"` | ||
| } `json:"sync_info"` | ||
| } `json:"result"` |
There was a problem hiding this comment.
Is there some tendermint struct we can import instead of hardcoding these?
There was a problem hiding this comment.
I tried changing this to import and use tendermint directly, the cometbft version we have imported and the actual tendermint version we are running on seems to have diference ( maybe due to diff between comet bft version between main and mainnet), retained this for now so that we can further test this
|
@p0mvn I have addressed all your prior comments except the one for using tendermint struct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Adds healthcheck endpoint that returns the following:
Testing and Verifying
WIP
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)