chore: add comments to eip-1559 code #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaddyMc
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
github-actions
bot
added
C:docs
p0mvn
approved these changes
Nov 3, 2023
x/txfees/keeper/mempool-1559/code.go
Outdated
Comment on lines
30
to
37
| - DefaultBaseFee: Default base fee, initialized to 0.0025. | ||
| - MinBaseFee: Minimum base fee, initialized to 0.0025. | ||
| - MaxBaseFee: Maximum base fee, initialized to 10. | ||
| - TargetGas: Gas wanted per block, initialized to 60,000,000. | ||
| - MaxBlockChangeRate: The maximum block change rate, initialized to 1/16. | ||
| - ResetInterval: The interval at which eipState is reset, initialized to 1000 blocks. | ||
| - BackupFile: File for backup, set to "eip1559state.json". | ||
| - RecheckFeeConstant: A constant value for rechecking fees, initialized to 4. |
There was a problem hiding this comment.
Should any of these be exposed via config?
There was a problem hiding this comment.
Not sure maybe @ValarDragon could input here?
Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
|
Going to merge this to start setting up a testnet from this commit on Dev's branch. Adam is working on the configs in the meantime |
ValarDragon
added a commit
that referenced
this pull request
Nov 3, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <[email protected]> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Nicolas Lara <[email protected]> Co-authored-by: PaddyMc <[email protected]> Co-authored-by: Roman <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Nov 10, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <[email protected]> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Nicolas Lara <[email protected]> Co-authored-by: PaddyMc <[email protected]> Co-authored-by: Roman <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Nov 10, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <[email protected]> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <[email protected]> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Nicolas Lara <[email protected]> Co-authored-by: PaddyMc <[email protected]> Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change