Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EstimateTradeBasedOnPriceImpact to stargate whitelist #6814

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

mattverse
Copy link
Member

Closes: #XXX

What is the purpose of the change

Adds EstimateTradeBasedOnPriceImpact to stargate whitelist so that contracts can query estimation on the price impacts.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@mattverse mattverse added the V:state/breaking State machine breaking PR label Nov 3, 2023
Copy link
Collaborator

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattverse mattverse merged commit d0a2337 into main Nov 4, 2023
1 check passed
@mattverse mattverse deleted the mattverse/estimae branch November 4, 2023 06:13
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants