feat: return bucket index of the current tick from LiquidityPerTickRange query #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
A:automerge
V:state/compatible/backport
p0mvn
commented
Nov 1, 2023
AlpinYukseloglu
approved these changes
Nov 1, 2023
| // Returns index of the bucket that corresponds to the current tick. | ||
| // For cases where there is no liqudity in the bucket but there may be liquidity to the right, the value will be -1. | ||
| // For cases where there is no liquidity in the bucket but there may be liquidity to the left, the value will be len(liquidityDepthsForRange). | ||
| // Otherwise, the index points to the bucket that corresponds to the current tick. |
There was a problem hiding this comment.
It might be useful to more concretely define "bucket" vs. "tick" either here or in docs
There was a problem hiding this comment.
The docs defines terminologies for these AFAIR!
There was a problem hiding this comment.
osmosis/x/concentrated-liquidity/README.md
Lines 1893 to 1895 in f721f73
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…nge query (#6805) Closes: https://app.clickup.com/t/86a19jj0x ## What is the purpose of the change This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick. This functionality is necessary for the SQS router in: #6785 By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time. ## Testing and Verifying Added unit test and also tested on localosmosis ## Documentation and Release Note - [x] Does this pull request introduce a new feature or user-facing behavior changes? - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A (cherry picked from commit 9755013)
p0mvn
added a commit
that referenced
this pull request
Nov 2, 2023
…nge query (#6805) (#6806) Closes: https://app.clickup.com/t/86a19jj0x ## What is the purpose of the change This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick. This functionality is necessary for the SQS router in: #6785 By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time. ## Testing and Verifying Added unit test and also tested on localosmosis ## Documentation and Release Note - [x] Does this pull request introduce a new feature or user-facing behavior changes? - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A (cherry picked from commit 9755013) Co-authored-by: Roman <[email protected]>
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://app.clickup.com/t/86a19jj0x
What is the purpose of the change
This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick.
This functionality is necessary for the SQS router in: #6785
By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time.
Testing and Verifying
Added unit test and also tested on localosmosis
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)