Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for slippage bound when LPing (backport #6788) #6790

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: improve error message for slippage bound when LPing (backport #6788) #6790

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2b713c
fix: improve error message for slippage bound when LPing (#6788)
p0mvn Oct 31, 2023
ba3c4cd
Update CHANGELOG.md
p0mvn Oct 31, 2023
5816dcf
Update CHANGELOG.md
p0mvn Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Misc Improvements

* [#6788](https://github.com/osmosis-labs/osmosis/pull/6788) Improve error message when CL LP fails due to slippage bound hit.

## v20.0.0

>>>>>>> e7517c2c (fix: improve error message for slippage bound when LPing (#6788))
p0mvn marked this conversation as resolved.
Show resolved Hide resolved
### Features

* [#6468](https://github.com/osmosis-labs/osmosis/pull/6468) feat: remove osmo multihop discount
Expand Down
2 changes: 1 addition & 1 deletion x/concentrated-liquidity/types/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (e InsufficientLiquidityCreatedError) Error() string {
if !e.IsTokenZero {
tokenNum = 1
}
return fmt.Sprintf("insufficient amount of token %d created. Actual: (%s). Minimum (%s)", tokenNum, e.Actual, e.Minimum)
return fmt.Sprintf("slippage bound: insufficient amount of token %d created. Actual: (%s). Minimum estimated: (%s)", tokenNum, e.Actual, e.Minimum)
}

type NegativeLiquidityError struct {
Expand Down