-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message for slippage bound when LPing #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
State machine compatible PR, should be backported
A:backport/v19.x
backport patches to v19.x branch
labels
Oct 31, 2023
AlpinYukseloglu
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix: improve error message for slippage bound when LPing * updates * changelog (cherry picked from commit e7517c2) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix: improve error message for slippage bound when LPing * updates * changelog (cherry picked from commit e7517c2) # Conflicts: # CHANGELOG.md
p0mvn
added a commit
that referenced
this pull request
Oct 31, 2023
) (#6790) * fix: improve error message for slippage bound when LPing (#6788) * fix: improve error message for slippage bound when LPing * updates * changelog (cherry picked from commit e7517c2) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Roman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:backport/v19.x
backport patches to v19.x branch
A:backport/v20.x
backport patches to v20.x branch
C:x/concentrated-liquidity
V:state/compatible/backport
State machine compatible PR, should be backported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
When slippage bound is hit during LP, the error message is confusing. This PR improves it.