Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list-env CLI command #6709

Merged
merged 4 commits into from
Oct 21, 2023
Merged

list-env CLI command #6709

merged 4 commits into from
Oct 21, 2023

Conversation

DongLieu
Copy link
Contributor

Closes: #4527

What is the purpose of the change

Add list-env for CLI

@DongLieu DongLieu changed the title cli for all Environment CLI for all Environment Oct 17, 2023
@hieuvubk hieuvubk added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Oct 17, 2023
@mattverse
Copy link
Member

Sweet, can you attach how the command looks like when actually ran on command line?

@DongLieu
Copy link
Contributor Author

Sweet, can you attach how the command looks like when actually ran on command line?

image

mattverse
mattverse approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, excited about this

cmd/osmosisd/cmd/change_environment.go Outdated Show resolved Hide resolved
@czarcas7ic czarcas7ic closed this Oct 17, 2023
@czarcas7ic czarcas7ic reopened this Oct 17, 2023
czarcas7ic
czarcas7ic approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on CI passing, thanks!

@czarcas7ic czarcas7ic changed the title CLI for all Environment list-env CLI command Oct 17, 2023
@czarcas7ic
Copy link
Member

@DongLieu can you please fmt the file, I would do it but its not in a repo I have write access to

@DongLieu
Copy link
Contributor Author

@DongLieu can you please fmt the file, I would do it but its not in a repo I have write access to

fmt the file, you mean:
image

@DongLieu
Copy link
Contributor Author

Or after commit change fmt:
image

@ValarDragon ValarDragon merged commit 8e252bc into osmosis-labs:main Oct 21, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: list environments
5 participants
@DongLieu @mattverse @czarcas7ic @ValarDragon @hieuvubk